search

fact-project / photon_stream

Explore the novel photon stream, based on the single photon extractor
6 stars 2 forks source link

Possible change of 3rd party library caused fail of muon detection test #83

Closed relleums closed 6 years ago

relleums commented 6 years ago

Not strictly related to the photon-stream. The test for the muon extraction fails without any changes coming from our site. We will have a look. Of course this also shows that the muon stuff should be moved out of the basic photon-stream repo.

dneise commented 6 years ago

If you are using continous integration tests on travis, you can switch on a weekly/monthly cron-job testing your master branch. This way you at least realize if tests fails due to upstream changes by 3rd libs.

https://docs.travis-ci.com/user/cron-jobs/

relleums commented 6 years ago

Laurits andI conclude that the muon package should be removed from the photon-stream package anyhow. It is a package for a specific analysis that just uses the photon-stream. There is no point in bothering the other users of the photon-stream with the problems of the muons. So I think we will 'solve' this issue for the photon-stream by moving the issue and code to the muon repository which I already created to host this code.

relleums commented 6 years ago

This issue is moved now into the muon repository.