Closed relleums closed 7 years ago
I investigated a bit more. Turns out that I made a mistake.
pyfact
can not be installed in usual python, this is where the missing dateutil
comes from. The photon-stream travis.yml does not tell travis to first install an anaconda environment. This is why the photon-stream could not install pyfact
. As we once defined anaconda to be a mandatory dependency it is up on the photon-stream travis tests to first install anaconda. So I incorrectly blamed pyfact
. Moreover there was already dateutil
in the setup.py:
install_requires=[
'numpy',
'scipy',
'matplotlib>=1.4',
'python-dateutil', <---
'pymongo>=2.7',
'simple-crypt',
'setuptools',
'sqlalchemy',
'pymysql',
'pandas',
'astropy',
'peewee',
'h5py',
'wrapt',
'tables', # pytables in anaconda
'python-dateutil', <---
],
No, I do not see a reason why pyfact should not be installable in a non-conda environment. This must be possible and work out of the box!
I found the problem!
It is that we no import __version__
from fact/__init__.py
in the setup.py file. As fact.__init__
also imports the time
module, datetutil
is a required now at setup parsing time, not only at install time.
No, I do not see a reason why pyfact should not be installable in a non-conda environment. This must be possible and work out of the box!
If that is true and important enough to warrant exclamation marks, please explain shorty, why the pyfact travis.yml starts with installing miniconda? Just for speed reasons? since conda install is sometimes more efficient than pip install?
If that is the case, I think one should make a point of not using miniconda in the tests .. thus clearly showing conda in not a requirement.
THis comes from a time where installing numpy on travis was just not possible using pip. I think since numpy no has binary wheels on pypi there is no real reason anymore to use conda on travis.
I am not yet sure where this comes from, the photon-stream tests on travis do not pass, because they can not install pyfact. However, on my machine pyfact and the photon-stream run fine. There seems to be an odd combination with the photon-stream, pyfact and travis.