search

fact-project / shifthelper

So we can sleep at night.
4 stars 0 forks source link

We still have the FlareAlertCheck in the code, but do not need it anymore #264

Closed dneise closed 6 years ago

dneise commented 6 years ago

It is always ugly to throw away stuff, which cost much time to develop, and is not used anymore. Still should we get rid of this?

https://github.com/fact-project/shifthelper/blob/6b841be6f28fb4cac2cb56b6758cfbfd06c55a8b/shifthelper/checks.py#L49

dneise commented 6 years ago

I think this question goes mostly to @MaxNoe

It is not urgent ... more like a reminder to ourselves

maxnoe commented 6 years ago

It is always ugly to throw away stuff, which cost much time to develop, and is not used anymore.

I really, really love throwing away unused code. Especially if it's mine.

maxnoe commented 6 years ago

I removed it in #267