Open erg opened 5 years ago
The last of these reports seems to be improved if it is rewritten as follows. (Since 'a' is also ignored, it is not a reaction with Chrome at all.)
ui/backend/cocoa/views/views.factor:
METHOD: char validateUserInterfaceItem: id event
[
self window :> window
window [
window world-focus :> gadget
gadget [
gadget preedit? [ 0 ] [
window event -> action utf8 alien>string validate-action
[ >c-bool ] [ drop self event SUPER-> validateUserInterfaceItem: ] if
] if
] [ 0 ] if
] [ 0 ] if
] ;
Oops, when you press ⌘ + a
, the 'a' input seems to be valid.
@kusumotonorio there seems to be a regression with the completion popup on macos.
For example, try and do fixnum-f<TAB>
(where that's the tab button).
Then pick the first thing on the list (fixnum-fast
) and then hit the space button.
It looks like this broken:
IN: scratchpad fixnum-f fixnum-fast
It should look like this:
IN: scratchpad fixnum-fast
I also tried it. Well, it's strange. It seems to work well with TAB and RET, but what is the difference?
As for mischief, I made the following changes. (" " → "c")
completion-popup H{
{ T{ key-down f f "TAB" } [ table>> row-action ] }
{ T{ key-down f f "c" } [ table>> row-action ] } ! " " -> "c"
} set-gestures
It works fine with "c".
By the way, why is it possible to choose complementation in RET? Is it defined somewhere else?
I found a solution to the problem @mrjbq7 pointed out. The modification will cause a loss of visual smoothness when accepting input from an input method and putting it into an editor gadget, but it cannot be helped.
I will test for a while.
I tried some input methods with other languages on macOS and Windows. I'm not sure these matter much, just something to note.
Arabic input
[ ] double-quote puts blinking cursor on the wrong side and typing another character teleports it leftwards
[ ]
⌘ + k
and⌘ + K
don't clear the output because it'sن
notk
This works with pinyin input because it's ak
until it's a Chinese character.Chinese (pinyin)
[ ] double-quote character
“ ”
alternates between code points 8220 and 8221, brackets are 12304 and 12305, etc【 】
Only a problem if people try to code with Chinese input methods enabled, which is doubtful.[ ] if character input is not finished, select-all + delete doesn't delete the line I tried this in Chrome and what happens is if you type
ni
then⌘+a
it adds to the input, likenia
, but in Factor it does a select-all. So basically we should consider disabling⌘-a
when in the middle of a character input.Chrome:
Factor: