search

factor1 / better-rest-endpoints

A WordPress plugin that serves up slimmer WP Rest API endpoints.
https://wordpress.org/plugins/better-rest-endpoints/
GNU General Public License v3.0
67 stars 25 forks source link

Added support for ACF options pages #25

Closed codecomp closed 5 years ago

codecomp commented 5 years ago

Added endpoints for single ACF options field and endpoint for all ACF option fields.

Used /options/acf to leave room for possibility of other options endpoints being added at a later date.

Was unsure as to why the include for includes/plugin.php had been included. I assumed this was for the plugin being used with a minimal WP load, so it has been included as this will not have an impact if added.

erwstout commented 5 years ago

This looks good to me, I can't test right at the moment, but I feel good about merging. @codecomp you tested locally and all seems well?

codecomp commented 5 years ago

Tested locally on WP 4.9.8 and ACF Pro 5.6.7 running PHP 7.0.3.

Nothing in there that should cause any issues, though always worth a second set of eyes on a different environment.

erwstout commented 5 years ago

I'll merge in the repo, but not launch the update to the WP repo yet. I'll try to carve out some time during the holiday. (get it? carve...... 🦃 ) Anyway, thanks for the PR as I don't have a ton of time to work on this plugin at the moment.

erwstout commented 5 years ago

Added w/ version 1.4.0 and released on the WordPress repo as 1.4.1