search

factor1 / prelude-wp

Prelude is a WordPress starter theme that helps you craft custom themes.
GNU General Public License v3.0
14 stars 3 forks source link

SVG Compression Creates Unintended Consequences #113

Closed erwstout closed 7 years ago

erwstout commented 7 years ago

I've found on more then one occaison running compressing SVG's via gulp images that some strokes inside the image are reduced creating the image to look off or missing components. By default right now we are compressing all image types including SVGs. Thoughts on just removing SVG compression and leaving it up to the dev to either:

A) Compress via OMGSVG or something similar B) Enable compression themselves via the Gulpfile

Any thoughts on this? I am leaning towards A.

erwstout commented 7 years ago

@mattada @mlpatt23

mattada commented 7 years ago

What are we using now? SVGmin? https://github.com/ben-eb/gulp-svgmin

erwstout commented 7 years ago

imagemin is what we are using now which has support for SVG. There’s a chance that it uses svgmin as a dependency but we are not directly using svgmin

On Thu, Jun 8, 2017 at 10:08 PM, Matt Adams notifications@github.com wrote:

What are we using now? SVGmin? https://github.com/ben-eb/gulp-svgmin

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/factor1/prelude-wp/issues/113#issuecomment-307296636, or mute the thread https://github.com/notifications/unsubscribe-auth/AJASeZJ5QS58VGOLwe9DCNMNtjeQwfZgks5sCNNbgaJpZM4N0wg_ .

--

eric stout

eric@factor1studios.com

factor1studios.com | twitter.com/factor1 | facebook.com/factr1