search

factor1 / prelude-wp

Prelude is a WordPress starter theme that helps you craft custom themes.
GNU General Public License v3.0
14 stars 3 forks source link

Consider removing Font Awesome by default #163

Closed mlpatt23 closed 5 years ago

mlpatt23 commented 5 years ago

A very early v5 script is located in inc/enqueues.php, and there is also the following line in assets/js/src/theme.js:

window.FontAwesomeConfig = { searchPseudoElements: true };

That line in particular seems to cause conflicts with other packages, possibly due to the amount of processing power it can take?

Also, in assets/scss/components/_social-menu.scss, I think we should remove all styles from the .menu-social ul li a selector and just leave a blank line for now, since these can vary depending on what version of Font Awesome is used (webfont or svg).

erwstout commented 5 years ago

Removed in v5.0.2 which has been published to npm