Feat: Provide SVG sprites loader

factorial-io / factorial-frontend-stack

Modern frontend tooling with minimal configuration

http://factorial-io.github.io/factorial-frontend-stack/

6 stars 1 forks source link

Feat: Provide SVG sprites loader #16

Open mlnmln opened 5 years ago

mlnmln commented 5 years ago

Generating SVG sprite map from assets.

SEE: https://github.com/kisenka/svg-sprite-loader

krisimmig commented 4 years ago

A working version is now in this feature, anybody wants to do some testing?

16-svg-sprite-loader/packages/svg-sprite

Some open questions:

is removing the fill and stroke colors from all svgs a good idea? I think it it is much easier that way to style them with css, but more complex SVGs will loose the coloring all together.
is this also working in IE11 and Edge? Haven't tested this, yet.
something else missing?

mlnmln commented 4 years ago

@krisimmig I'll have a look today – sorry for the late feedback.

mlnmln commented 4 years ago

I can't get this running in the example folder after 30m trying out. Could you provide a PR with changes in the example folder that get this running? Thanks.

Some concerns:

How would this work in a twig template / PHP environment? How does the spritemap get injected in that case?
Does this conflict with our existing file loader? We import svg fonts in CSS in our usage example?
For IE11 compatbility we usually need this polyfill here https://github.com/jonathantneal/svg4everybody is that included?

krisimmig commented 4 years ago

the spritemap is injected by the sprite-loader itself
there is a conflict when loading svg files from css at the moment which causes an error in the build
IE11 is working without the ployfill

I will try to fix the svg import from css files..

mlnmln commented 4 years ago

Sounds good to me. I pushed some changes a couple of days back. Make sure to pulle them.