factorial-io / factorial-frontend-stack

Modern frontend tooling with minimal configuration
http://factorial-io.github.io/factorial-frontend-stack/
6 stars 1 forks source link

Feat: Make ENV settings for path configurable #41

Open mlnmln opened 5 years ago

mlnmln commented 5 years ago

UC: We need different path settings for our build on local and remote for historic reasons.

IS hardcoded in CONSTANT at https://github.com/factorial-io/factorial-frontend-stack/blob/master/packages/pattern-lab/index.js#L8

SHOULD: this should be configurable.

mlnmln commented 5 years ago

Current format throws when using fish shell.

This must be configured somewhere else.

stmh commented 5 years ago

Pass the environment variable directly when calling exec. See https://stackoverflow.com/questions/7824789/nodejs-set-environment-variable-for-exec#7825732