search

factoriotools / factorio-docker

Factorio headless server in a Docker container
https://hub.docker.com/r/factoriotools/factorio/
MIT License
1.08k stars 241 forks source link

docker-dlc.sh overwrites mod-list.json #544

Closed sarcasticgoat closed 2 weeks ago

sarcasticgoat commented 2 weeks ago

The docker-dlc.sh script always overwrites the $MODS/mod-list.json file. This make it impossible to use any mods outside of the 3 defined in https://github.com/factoriotools/factorio-docker/blob/6916fcb1500f9f04e62a3e16f4d1552362042f74/docker/files/docker-dlc.sh#L7.

Fank commented 2 weeks ago

Can you please share your mod-list.json and explains what happens? The docker-dlc.sh file only touches the provided mods of the dlc, therefore all other mods should not be touched. In my tests i added some mods enabled and disabled, and they were not changed by docker-dlc.sh.

sarcasticgoat commented 2 weeks ago

This is a classic PEBKAC - I'm an idiot and didn't realize that I was loading an older save that did not have mods incorporated... Issue closed