search

factset / quart-openapi

Module for Quart to add Flask-RESTPlus like functionality
https://factset.github.io/quart-openapi/
Other
82 stars 22 forks source link

Quart 0.12 breaks API #45

Closed devdupont closed 4 years ago

devdupont commented 4 years ago

Quart 0.12 made a small breaking change to Quart.add_url_rule that causes the following error:

TypeError: add_url_rule() got multiple values for argument 'provide_automatic_options'

This is because the methods parameters appears to have moved in the function call.

Setting methods=methods in pint.py line 199 fixed this for me locally.

zeroshade commented 4 years ago

Thanks for pointing it out, i'll take a look and push out a fix.

xandrade commented 4 years ago

Hello,

Quart 0.12 made a small breaking change to Quart.add_url_rule that causes the following error:

TypeError: add_url_rule() got multiple values for argument 'provide_automatic_options'

This is because the methods parameters appears to have moved in the function call.

Setting methods=methods in pint.py line 199 fixed this for me locally.

I also got same error. Please let us know how we can support

zeroshade commented 4 years ago

@xandrade @flyinactor91

quart-openapi version 1.6.0 should be deployed to pypi momentarily which will fix this issue. I'll comment again once the deploy has happened. Please give it a try afterwards and confirm that everything works fine for you both. thanks

zeroshade commented 4 years ago

Ok, Pypi deployment has completed, in my local testing everything worked correctly (along with the travis build) so please confirm that updating to version 1.6.0 of quart-openapi fixes the issues you were both having. :)

devdupont commented 4 years ago

Fixed it for me. Thanks for the update!