factsmission / synospecies

Using Plazi Data to find currently accepted scientific names
https://synospecies.plazi.org/
MIT License
5 stars 1 forks source link

Add "oh, yeah?"-feature #48

Closed retog closed 2 years ago

retog commented 3 years ago

When synospecies presents a synonym the user should be able to click on a button/link to see the full justification on why synospecies considers this name a synonym of the name the user searched for.

nleanba commented 3 years ago

some basic justifications are now implemented

nleanba commented 3 years ago

We have two queries tasked with finding synonyms:

  1. Using genus & species. Will say "Has queried genus & species" or "Has same genus & species as another synonym"
  2. Using an already found taxon concept. Will say "Found to be a synonym for {tc}"

More information is difficult to get as the 2nd query does a lot of stuff all at once.

nleanba commented 3 years ago

This feature currently needs enablement via the settings. Please close the issue if this is satisfactory, @retog .

retog commented 3 years ago

Thanks, @nleanba for looking into this so quickly!

I would like to see the full chain of justification with the reference to the respective treatments.

Example

Query: Aius bius

Justification for the result Pius qius, Anderson 2020

retog commented 3 years ago

In principle, there could be multiple independent justifications on why Pius quis, Anderson 2020 is a synonym of Aius bius, while presenting all justification paths would be nice just having one justification is good enough.

nleanba commented 3 years ago

It already shows multiple justifications if a taxon concept is found via multiple queries.

A chain as envisioned by you would necessitate adding more queries and/or splitting up query № 2, which would slow down synospecies quite a bit. If it were to be implemented (which seems tedious), it should definitely be an opt-in feature and using the existing queries only normally.

retog commented 3 years ago

I think it should be implemented in a way that does not slow down synospecies. The justification shall only be computed if and when the user requests it for a particular result. The feature is important as it saves us from manually having to do research on complaints about wrong synonyms.

retog commented 3 years ago

image This brings us back to #45 but here this is not a synonym because it has the same genus/species but because it explicitly deprecated in http://treatment.plazi.org/id/03AE87BFE84EFFD0A57E0DFAFB6AFAEC.