factsmission / synospecies

Using Plazi Data to find currently accepted scientific names
https://synospecies.plazi.org/
MIT License
5 stars 1 forks source link

Update Material Citation display #99

Closed nleanba closed 6 months ago

nleanba commented 1 year ago

(See https://github.com/plazi/names_LOD/issues/133):

(See https://github.com/plazi/treatments-xml/issues/11):

UX:

nleanba commented 1 year ago

Screenshot from 2023-04-03 19-28-20

Current UI for reference

nleanba commented 1 year ago

Proposal

Show only the amount of material citations under each treatment, with a button (1) to expand it. The expanded sheet floats above the content and does not push the following treatments down.

In it, each material citation gets a row as follows: (from left to right)

image

@retog @myrmoteras opinions?

retog commented 1 year ago

Just something minor: Instead of "Cited Materials (3)" say "3 Cited Materials", or even more understandable for my lay ears "3 specimens referenced".

nleanba commented 1 year ago

How's this? (currently live as such) image

nleanba commented 1 year ago

@retog @myrmoteras opinions?

image

note: clicking anywhere on the label “X specimens referenced” opens the popup. Making the whole text look like a button (with background etc. looked way too visually heavy and distracting)

Unless either of you has some remaining issues or suggestions for this display, I consider this done and will close this issue.

myrmoteras commented 1 year ago

I would use "material citation" since this is the term we coined for a reference of one or multiple specimens used in an analysis, which is used this way in TDWG DWC https://dwc.tdwg.org/terms/#materialcitation and also in the GBIF data model https://www.gbif.org/occurrence/search?basis_of_record=MATERIAL_CITATION&occurrence_status=present basisOfRecord

myrmoteras commented 1 year ago

should we change "GBIF occurrence ID" to "GBIF material citation"?

if so we could also change "GBIF specimen ID" to "GBIF preserved specimen" image

myrmoteras commented 1 year ago

@tcatapano terminology to be discussed?!

retog commented 1 year ago

should we change "GBIF occurrence ID" to "GBIF material citation"?

The name is taken from the attribute ID-GBIF-Occurrence which is distinct from ID-GBIF-specimen. Whatever brings more clarity helps, but we should then make sure that the new terms are used consistently.