search

facultyai / faculty-sync

Synchronise a local directory with your Faculty platform workspace
https://pypi.org/project/faculty_sync/
Apache License 2.0
10 stars 1 forks source link

Rebrand sml-sync to faculty-sync #42

Closed tcbegley closed 5 years ago

tcbegley commented 5 years ago

ASI Data Science (formally "Advanced Skills Initiative Limited", UK company number 08873131) has been renamed "Faculty Science Limited" as of 4th February 2019.

This PR removes all references to ASI Data Science and SherlockML, updating them to Faculty. It also updates some of the implementation that relied on sml to faculty and faculty_cli.

I haven't updated the gif in the readme which still has SherlockML branding in it.

@sbalian @pbugnion

pbugnion commented 5 years ago

Thanks so much for doing this. I'll take a look tomorrow morning.

pbugnion commented 5 years ago

I introduced backwards compatibility on the configuration files and released an alpha version off d14f562. You should now be able to:

pip install faculty-sync

Before merging this, I'd like to completely remove the dependency on faculty-cli. Reducing dependencies is just a good thing (specially since faculty-cli is not trivial to install on Windows), and faculty_cli was never meant to be used as a library.

Now that we have better faculty libraries, this should be possible. I think this means:

Happy to make those changes if you want. Now that we have an alpha out, it's much less pressing.

tcbegley commented 5 years ago

Good call on the configuration files.

We used faculty-cli initially to minimise changes, but your reasons for wanting to ditch it make sense. I'm happy to try that if you don't mind? It's a good excuse for me to get a bit more familiar with the faculty library.

tcbegley commented 5 years ago

@pbugnion removing faculty-cli turned out to be pretty straightforward, so this is ready for another look.

faculty_cli.shell is just vendoring shlex.quote for Python 2 compatibility, but since faculty-sync is already Python 3 only I just imported shlex.quote directly instead. faculty_cli.auth I have replaced with the accounts client from faculty.

pbugnion commented 5 years ago

This is great, thank you!

I'm going to push a couple more changes and then cut a full 0.4.0 release.