Open imrehg opened 4 years ago
In general, the Python clients in this library rely on defaults set on the backend rather than providing their own defaults.
We could either:
I'd rather not promise a particular backend-set value as this introduces unnecessary coupling.
What do other similar client libraries do?
In
JobClient
, thelist_jobs
function has alimit
argument, which sets the number of jobs returned in a single request. The default value is isNone
in the library, which means "use the default limit from the backend service". That default value is (I believe)10
.https://github.com/facultyai/faculty/blob/master/faculty/clients/job.py#L314
Had a request to use that upstream default value in the library to make the effect of different values clearer. Otherwise interpreting the behaviour of
None
is difficult (for example will there be paging in that case or all records are returned?)