facultymatt / angular-unsavedChanges

angular-unsavedChanges
175 stars 81 forks source link

Fix problem with don't cleaning removeFunctions after tear down #21

Closed dmytroyarmak closed 10 years ago

dmytroyarmak commented 10 years ago

The problem that array with function to unbind event listeners is never cleaning. So it cause memory leak and unexpected behavior of angular.js (It brokes routing for angular.js v1.3.0)

wawyed commented 10 years ago

Can we get this fix in please? :+1:

facultymatt commented 10 years ago

Thanks for this PR! I will get this merged in this evening.

On Tue, Oct 28, 2014 at 1:37 PM, wawyed notifications@github.com wrote:

Can we get this fix in please? [image: :+1:]

— Reply to this email directly or view it on GitHub https://github.com/facultymatt/angular-unsavedChanges/pull/21#issuecomment-60797804 .

Matt Miller

Web Master 609-335-4417 matt@superpedestrian.com https://www.superpedestrian.com/ https://www.google.com/url?q=https%3A%2F%2Fwww.superpedestrian.com%2F&sa=D&sntz=1&usg=AFQjCNHLEDFaMLgggeXL8rh4gGlNfN0WSA


Superpedestrian Inc. 84 Hamilton St. Cambridge, MA 02139

This message is intended only for the addressee named above. If you are not the intended recipient of this message, you are hereby notified that you must not use, disseminate, or copy it in any form or take any action in reliance upon it. If you have received this message in error, please delete it and any copies of it from your email system and reply immediately to the sender at the address shown above. This message may contain confidential and/or proprietary information. Neither confidentiality, nor any proprietary rights are intended to be waived or lost by any error in transmission.