facultymatt / angular-unsavedChanges

angular-unsavedChanges
175 stars 81 forks source link

Replacement for confirm #41

Open IgalOre opened 9 years ago

IgalOre commented 9 years ago

Hello, i had discovered angular-unsavedChanges project throw Googling, and so far everything looking good and promising. So far i got 2 questions: 1) Is there any specific reason why this project not published on NPMJS ? (except of capital letter in name) ?

2) If you would be required to replace windows.confirm with alternative dialog pop-up as one from angular UI-Bootstrap modal pop-up http://angular-ui.github.io/bootstrap/#/modal , how would you do so ?

Thank you in advance ...

cstephe commented 9 years ago

as for your second question, I had to fork it in order to customize dialog behavior. custom modals are non blocking unlike confirm, so it is not a trivial thing. if it helps here is my commit history on my fork: https://github.com/cstephe/angular-unsavedChanges/commits/cniUpdates

IgalOre commented 9 years ago

It does helps, thank you Chris; it would spare few code tinkering ...

menelaosbgr commented 9 years ago

cstephe, I see you have made changes to your repo but have you uploaded a full demo showing the custom dialog functionality???

cstephe commented 8 years ago

@menelaosbgr nope I'm not PRing it, If you want to go ahead, but it needs work to be an universal solution.