facundoolano / advenjure

A declarative text adventure engine
https://facundoolano.github.io/advenjure/
Eclipse Public License 1.0
314 stars 18 forks source link

consider dropping Clojure (target only ClojureScript) #50

Open facundoolano opened 7 years ago

facundoolano commented 7 years ago

The engine was written for Clojure because that was what I was learning at the time, but it feels like 99% of the time a user of this library will want to target primarily or exclusively the browser, because who wants to install clojure and play from the terminal?

Even while the conditional code was reduced a lot, removing reader conditionals in the requires alone would improve the readability of the code a lot.

Also, the project will become simpler and development process easier; I imagine new opportunities for improvement will become apparent once we start targeting a single host.

Obviously, unit tests and a better development workflow (i.e. better hot reloading without having to restart the game, fix whatever makes the figwheel repl unresponsive from time to time, etc.).

If you are reading this and think dropping terminal support is a bad idea, please chime in!

Gman98ish commented 7 years ago

Not saying you shouldn't drop terminal support, but it can compile to a .jar file which can be run so long as you have the java runtime installed (which pretty much everyone does)

facundoolano commented 7 years ago

If you are a developer then yes, you probably have jre (although I know devs that specifically avoid to have it). But you generally want non developers to play your game as well.

ghost commented 5 years ago

A game can be compiled with GaalVM and it will not require jre.

jprudent commented 3 years ago

You can drop Clojure (JVM) support and still have real terminal support if you also target Nodejs

I think it's not a bad idea to consider CLJS only