search

facundoolano / aso

Tools for app store optimization on iTunes and Google Play
MIT License
720 stars 144 forks source link

TypeError: Cannot read property 'split' of undefined #13

Closed vishaletm closed 5 years ago

vishaletm commented 6 years ago

TypeError: Cannot read property 'split' of undefined I am getting this error while making request for aso.visibility and aso.app

Error stack trace Node\aso\node_modules\google-play-scraper\lib\app.js:49:64)\ image

facundoolano commented 6 years ago

This is because ASO uses an old version of google-play-scraper. Updating to the latest version should fix it, but this also requires going through all the recent API changes in the scraper and making sure the ASO code is updated for them.

vishaletm commented 6 years ago

Is this issue added to pipeline? Can I fix this with somebody's help? Lot of new changes are coming to google play.

#ASO Earthquake: Google Play update reveals keyword installs to developers

facundoolano commented 6 years ago

@vishaletm If you want to try it the fix would be updating to the latest gplay scraper version, and going through each of the ASO methods to see if something breaks. Some stuff will most likely break, at this point you'd have to debug the ASO code, possibly checking the gplay commit history to see what has been changing lately.

It's not trivial work, but I currently don't have much time to do it myself.

TheBlackList95 commented 5 years ago

@facundoolano Hi, please all (aso) module not working, it leaves : UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'split' of undefined... What's the problem, how can i fix this please i'm stuck now.

igorbest89 commented 5 years ago

@facundoolano also I have problem whith aso can you help plz

vishaletm commented 5 years ago

@facundoolano I tried to change the version of scrapper. Seems working. Could you please look into my Pull Request?

TheBlackList95 commented 5 years ago

I will verify your code for now but i dont know what hapen, what is the principe of getting ketting keywords from google play ? because your google play scrapper works really fine, you are good, but aso package not working i cant see why

Le jeu. 18 oct. 2018 à 08:52, Vishal K M notifications@github.com a écrit :

@facundoolano https://github.com/facundoolano I tried to change the version of scrapper. Seems working. Could you please look into my Pull Request https://github.com/facundoolano/aso/pull/18?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/facundoolano/aso/issues/13#issuecomment-430895377, or mute the thread https://github.com/notifications/unsubscribe-auth/ApodwR1pg3G0FtMYyrXO-2--vrE3Gwfaks5umCT6gaJpZM4TVkfm .

vishal-km commented 5 years ago

Done a test for suggest only

aso.suggest({
   strategy: aso.SIMILAR,
   appId: 'com.ubercab.uberlite',
   num: 5}).then(function(result) {

   console.log(result);
}, function(err) {
   console.log(err);
});

Result obtained ['app', 'taxi', 'https', 'time', 'driver' ]

TheBlackList95 commented 5 years ago

Cooool, you are genius bro don't give up, im here with you, we have to make it running again

Le jeu. 18 oct. 2018 à 10:31, vishal-km notifications@github.com a écrit :

Done a test for suggest only

aso.suggest({ strategy: aso.SIMILAR, appId: 'com.ubercab.uberlite', num: 5}).then(function(result) {

console.log("Initialized user details"); // Use user details from here console.log(result); }, function(err) { console.log(err); });

Result obtained ['app', 'taxi', 'https', 'time', 'driver' ]

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/facundoolano/aso/issues/13#issuecomment-430922571, or mute the thread https://github.com/notifications/unsubscribe-auth/ApodwZ7LirY1QjoU7vxeYPPoy_wcXNamks5umDx5gaJpZM4TVkfm .

facundoolano commented 5 years ago

should be fixed now.

TheBlackList95 commented 5 years ago

Really ? Fixed now ? Everything is good ?

On Mon, Nov 19, 2018, 17:04 Facundo Olano notifications@github.com wrote:

should be fixed now.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/facundoolano/aso/issues/13#issuecomment-439967163, or mute the thread https://github.com/notifications/unsubscribe-auth/ApodwWgafEsJy7Yixzu0HSUcr_JuAHNnks5uwuSLgaJpZM4TVkfm .

facundoolano commented 5 years ago

Just published a new version. If you still see an error, please open a new issue.

TheBlackList95 commented 5 years ago

Good. Proud of you genious. I'll make a unit test to each function then i'll report if any of them not working correctly

On Mon, Nov 19, 2018, 17:09 Facundo Olano notifications@github.com wrote:

Just plublished a new version. If you still see an error, please open a new issue.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/facundoolano/aso/issues/13#issuecomment-439969037, or mute the thread https://github.com/notifications/unsubscribe-auth/ApodwXi_tnGLqW0BWCBpSNTrJ4cIXkxjks5uwuXNgaJpZM4TVkfm .