facundoolano / feedi

A personal news aggregator and Mastodon client
GNU Affero General Public License v3.0
888 stars 28 forks source link

Locked out of feed edit page when using '/' in name #65

Open morganridel opened 9 months ago

morganridel commented 9 months ago

Hello, nice project!

I'm trying it out for myself and it seems that using a '/' character in a feed name prevent access to any url using the feed name. I know bugs should be expected, I'm sharing it just in case.

image

STRs:

I had to manually edit the sqlite database to fix this.

I guess you could disallow forward slashes or maybe url-encode them?

facundoolano commented 9 months ago

Thanks for reporting.

I guess you could disallow forward slashes or maybe url-encode them?

Yes I should do one of things things. There's the alternative of not using names in the urls, but at least for the filtering I think it's desirable to have it displayed in the url (arguably the same could be done by using id + slug).

A related set of bugs happens with using spaces in the names, that should also be handled.