Incorrect reviews when sort and num both options are specified

facundoolano / google-play-scraper

Node.js scraper to get data from Google Play

MIT License

2.28k stars 625 forks source link

Incorrect reviews when sort and num both options are specified #594

Open puneetghodasara opened 1 year ago

puneetghodasara commented 1 year ago

Operating System: N/A
Node version: N/A
google-play-scraper version: 9.1.1

Description:

When sort and num both options are specified, library fetches 150 (hardcoded) reviews and slice them with default array sort option. Hence, when num (<150) is specified, it will truncate [num...150] reviews and nextPaginationToken will start from 150 instead of num + 1.

Example code:

// Put code to reproduce the issue here

Error message:

No error message.

Put error message here

puneetghodasara commented 1 year ago

I have a fix ready with test cases, however I do not have permission to create branch or create pull request. I am happy to submit the CR/PR if I get a permission to contribute in this repository.