search

facundoolano / google-play-scraper

Node.js scraper to get data from Google Play
MIT License
2.35k stars 634 forks source link

Test appId no longer valid #686

Open jonathansampson opened 3 months ago

jonathansampson commented 3 months ago

This app no longer exists. As a result, the test fails. cc @jbigman

https://github.com/facundoolano/google-play-scraper/blob/60261ade67e88099ba75ca65d5c810255caf7851/test/lib.app.js#L202

jonathansampson commented 3 months ago

That ID appears to be for Pocoyo Playset Learning Games, last updated on April 18, 2017. I cannot find anything that old, but I did find P House - Numbers, which was last updated on October 2, 2017.

Would this be a satisfactory replacement for air.com.zinkia.playset?

jonathansampson commented 3 months ago

There are a few appIds which no longer exist, and therefore cause several tests to fail. Or, alternatively, perhaps a test shouldn't fail if an appId yields a 404 response. Instead, those example should be logged and manually reviewed?

facundoolano commented 3 months ago

Ideally we should update those tests with new app ids, preferably some big names that are less likely to be removed.