search

facundoolano / google-play-scraper

Node.js scraper to get data from Google Play
MIT License
2.32k stars 629 forks source link

Added new about the developer section to the `app` method #693

Open renatosrounds opened 1 week ago

renatosrounds commented 1 week ago

Hello,

I wanted to add the new "About the developer" section which I think will soon be mandatory to all apps. (screenshot as reference)

I split it in its own object so its better organised. Let me know if you think that is okay.

If possible let me know what else I need to do for this PR to add this feature in the scraping.

I saw the tests are failing. I will add this change to the tests as well.

Screenshot 2024-09-24 at 09 59 48

facundoolano commented 1 week ago

Let's call it devInfo, and update the readme please and the tests accordingly, please.

facundoolano commented 1 week ago

Also I don't think this should be a separate object (I mean it would be best to have all dev fields into a separate object, but we're already using separate developerId, developerEmail, etc, and I prefer not to introduce a breaking change).

You should use developerLegalName or developerCompany or something similar to avoid confusion, Likewise check whether the email in the about section is different from the email we already have and rename if necessary.

renatosrounds commented 1 week ago

Ok I will remove them from the object. I have noticed in some apps that the email can be different between this new section and the support email in the about section.

renatosrounds commented 6 days ago

@facundoolano On the apps that are used on the README and the tests, I see that the About the developer section is not present yet. So in the README I put the values as undefined while in the tests I just added a new one instead of updating the validation function. Do you have a better idea on how I can handle this? Should I change the app in the tests for example?

facundoolano commented 6 days ago

Code looks good, the only thing is that for the test, you should try to choose an app that's less likely to be removed to reduce the chances of breaking the test down the line. Did you chose this developer for some particular reason?

renatosrounds commented 5 days ago

No you are right. I will find an app that has the information and has less chance of being removed.

renatosrounds commented 1 day ago

@facundoolano I updated the app with soundcloud which should be more solid as a test