Closed ppetrescu-wasdi closed 2 years ago
About the support of the type now is ok: the lib before stopped if the new type was not known. Now it just says something but it works, it is not blocking.
The params parameter has been added exactly to avoid to change the signature of the method every time we release new data.
Is true that we need to improve the documentation on this.
the Python library does not consider the newly added providers (i.e. Copernicus Marine).
:param sPlatform: satellite platform:(S1|S2|S3|S5P|VIIRS|L8|ENVI|ERA5)
sQuery = "( platformname:" if sPlatform == "S2": sQuery += "Sentinel-2 " elif sPlatform == "S1": sQuery += "Sentinel-1" elif sPlatform == "S3": sQuery += "Sentinel-3" elif sPlatform == "VIIRS": sQuery += "VIIRS" elif sPlatform == "L8": sQuery += "Landsat-*" elif sPlatform == "ENVI": sQuery += "Envisat" elif sPlatform == "S5P": sQuery += "Sentinel-5P" elif sPlatform == "ERA5": sQuery += "ERA5" else: sQuery += sPlatform
More, some of the new providers are introducing new parameters. Since this new parameters are not explicitly part of the signature of the
searchEOImages
function, the user can only pass them through theaoParams
dictionary.aoParams = { "protocol": "SUBS", "dataset": "dataset-oc-glo-bio-multi-l3-chl_300m_daily-rt", "variables": "CHL CHL_error CHL_flags" }
Either the documentation of the function is updated (to add more information about how to construct the dictionary in each case) or the specific parameters should be added to the signature of the function.