search

fadhly-permata / flutter_money_formatter

"FlutterMoneyFormatter" is a Flutter extension to formatting various types of currencies according to the characteristics you like, without having to be tied to any localization.
https://pub.dartlang.org/packages/flutter_money_formatter
Other
85 stars 106 forks source link

FormatException thrown when I used Indonesia language as the app localisations #9

Closed dwhub closed 5 years ago

dwhub commented 5 years ago

FormatException is thrown when I used Indonesia language as the Applocalizations in both iOS and Android. It was working fine if I set the device language to English but when I switch to Indonesia language I got this FormatException(2, 32).

To Reproduce Steps to reproduce the behavior:

  1. Create flutter app localisations (in this case I use "en", and "id")
  2. Go to Settings in iOS device or Android device emulator
  3. Switch the language to Indonesia
  4. Start the app and you will see the format exception error.

Expected behavior The money value should be formatted correctly regardless of the language.

Screenshots

Screen Shot 2019-08-18 at 10 46 13 am

Smartphone (please complete the following information):

Gerrel commented 5 years ago

Fix is available with pull request: https://github.com/fadhly-permata/flutter_money_formatter/pull/8#issue-307499754

fadhly-permata commented 5 years ago

@Gerrel: Thanks for your contribution, I'll check this out, when everything is OK, then I'll merge it on the main branch 👍

fadhly-permata commented 5 years ago

@dwhub: Fixed by @Gerrel, and have been released (v0.8.3)