search

fadion / Maneuver

Easily deploy Laravel projects via FTP or SFTP, using Git for versioning
MIT License
174 stars 26 forks source link

Add vendor's or composer's files only to deploy #2

Closed overflowsith closed 9 years ago

overflowsith commented 9 years ago

In the sadly case that you have not ssh access and nobody can run composer dump-autoload or composer install this commit helps you to deploy even those files

fadion commented 9 years ago

That can be easily done by removing /vendor and composer files from .gitignore. Or am I missing something?

overflowsith commented 9 years ago

You have a point (and I agree with you), but my bosses don't like to keep under our git all the vendor. I know, the delta is really small after the first deploy but they prefer to keep the project as small as possible.

Obviously feel free to refuse my PR :) I just wanted to share with you my changes because this package saves my day many times and I thought it was a good idea to include those changes.

If you think that can be a better way include this step under a command argument I can change in that way the script

thanks :)

fadion commented 9 years ago

Sure, I understand your point. Let me think about it and I'll return to it.

overflowsith commented 9 years ago

Ok

thank you

fadion commented 9 years ago

The biggest problem with adding files outside of Git is that it forces them to be uploaded each time. There's no way to have version control when you lack, well... version control. Even if it was optional (configurable), it still is such a minor use case that I don't think it's worth implementing.

Sorry, but I have to reject the commit. If I ever find a good solution for this, I'll surely implement it.

overflowsith commented 9 years ago

You are right. Sorry if I waste your time and thank you again for your package :)