fadion / Maneuver

Easily deploy Laravel projects via FTP or SFTP, using Git for versioning
MIT License
174 stars 26 forks source link

Laravel 5.5 support broken? #29

Closed tbergeron closed 6 years ago

tbergeron commented 6 years ago

While on the dev-l5 branch, I'm getting this error while trying to deploy on an upgraded Laravel 5.5 install:

anon@devbox:~/$ php artisan deploy:list
  [ReflectionException]
  Method Fadion\Maneuver\Commands\ListCommand::handle() does not exist

anon@devbox:~/$ php artisan deploy
  [ReflectionException]
  Method Fadion\Maneuver\Commands\DeployCommand::handle() does not exist

I know there has been a lot of changes between 5.1 and 5.5, some about commands so maybe something needs tweaking.

I'll try to figure out what exactly did change and broke Maneuver and report my findings here.

Thanks!

forelabs commented 6 years ago

I have simply added

    public function handle() {
      $this->fire();
    }

in vendor/fadion/maneuver/src/Fadion/Maneuver/Commands/DeployCommand.php for now, so it works. Looks like fire() call has been reworked to handle()

tbergeron commented 6 years ago

@forelabs thanks for pointing that out! I didn't have time to check why it was happening, if this works for me as well I'll open up a PR so @fadion can get this fixed.

tbergeron commented 6 years ago

@forelabs I opened a PR with your fix thanks to you! You're awesome! 👍

tbergeron commented 6 years ago

I'll leave this opened while @fadion checks if the PR is okay.

fadion commented 6 years ago

The package now supports Laravel 5.5 from version 2.1.0. I'm closing this issue, but please let me know if anything's wrong.