search

fadmaa / grefine-rdf-extension

An extension to Google Refine that enables graphical mapping of Google Refine project data to an RDF skeleton and then exporting it in RDF format
http://refine.deri.ie
Other
94 stars 55 forks source link

Run it under a sub-path #51

Closed wikier closed 12 years ago

wikier commented 12 years ago

Related with another issue already reported to the main project (http://code.google.com/p/google-refine/issues/detail?id=576), here the necessary patches for also running the rdf extension under any sub-path (but at the same time keeping backward compatibility to run it in the root).

wikier commented 12 years ago

I tested, and almost everything looks to be correctly working, both at root or under another path.

But I'm having an issue loading a project: the loading dialog keeps there forever. Debugging it I noticed that it can't access the sindice service, trying to call (depending where you are running it):

http://localhost:8080/extension/rdf-extension/services/sindice?callback=jsonpXXXXXXXXXXXXX http://localhost:8080/refine/extension/rdf-extension/services/sindice?callback=jsonpXXXXXXXXXXXXX

Since I can't reproduce this issue with the original code, might be a lateral effect caused by my modifications, but I can't detect exactly which one. So it should be fixed before accept this pull request.

fadmaa commented 12 years ago

do you know why it is not shown at https://github.com/fadmaa/grefine-rdf-extension/network? did I do the merge wrongly?

wikier commented 12 years ago

no idea why the network graph doesn't show the merged pull requests... but the patch looks to be applied

wikier commented 12 years ago

btw, before apply the patch, did you get any conclusion about the issue? could you reproduce it?

I guess this is the troubled code: https://github.com/fadmaa/grefine-rdf-extension/blob/master/module/scripts/menu-bar-extensions.js#L75

fadmaa commented 12 years ago

the network graph looks good now... wasn't showing the merge for some reason...

Are you getting an exception related to Xerces?

wikier commented 12 years ago

no, nothing directly related with xerces