search

fadushin / esp8266

This repository contains source code for the ESP8266.
BSD 2-Clause "Simplified" License
73 stars 22 forks source link

Simplifications #9

Closed costastf closed 6 years ago

costastf commented 7 years ago

Hi Fred, I went over the uhttpd code since I am using it and have made some changes, which are mostly simplifications, semantic renames and restructures and some introspection lookups for http verbs and http codes that would help the extendability of the code. I hope you don't mind the range of the changes. Please do not hesitate to contact me for for anything and again thank you for this amazing module!

fadushin commented 7 years ago

I don't mind at all! I will review this shortly. I have been away from ESP development, and I will get back to it in short time. Thank you for your contributions! (Do the changes pass the tests?)

costastf commented 7 years ago

Hi Fred,

Sorry,I didn't notice any testing suite so I don't know.

Kind regards Costas

On Jun 28, 2017 18:00, "Fred Dushin" notifications@github.com wrote:

I don't mind at all! I will review this shortly. I have been away from ESP development, and I will get back to it in short time. Thank you for your contributions! (Do the changes pass the tests?)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fadushin/esp8266/pull/9#issuecomment-311706166, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbFa4eMyfvc9O4EYyj4j7GxdLcFT8Tiks5sIni5gaJpZM4OCOme .

fadushin commented 6 years ago

I had to revert this merge, because the tests were failing, and I don't really have time to look into the changes. Perhaps make corrections to fix the tests, and then resubmit? Sorry!

costastf commented 6 years ago

Hi Fred, yes, of course I will look into the tests and make sure that everything works and I will make a new PR as soon as I have time to work on it. Sorry for the trouble.