Added incr command for strings

faeldt / redis-mock

Node.js redis client mock

112 stars 156 forks source link

Added incr command for strings #11

Closed tatsuya closed 11 years ago

tatsuya commented 11 years ago

It would be useful for increment test.

jimmystridh commented 11 years ago

Working fine in my tests; hoping @faeldt will merge and include in npm.

faeldt commented 11 years ago

@tatsuyaoiw this is cool and I appreciate the effort but unfortunately we just did a bit of a refactoring effort to fix the typing problems with the tests. Could I ask you to have a look at 0.2.0 and update this to fit in with how things are now?

tatsuya commented 11 years ago

@faeldt I updated code to fit 0.2.0 style.

lahabana commented 11 years ago

This looks good! Can you just:

Add a test to check that it returns an error if we try to use incr against something that is not a string (a hash or a list for example).
Check the error message on your test

tatsuya commented 11 years ago

OK, I'll let you know when I add that tests.

faeldt commented 11 years ago

Thanks. We'll get this merged and into a 0.2.1 release once you get back to us with that.

tatsuya commented 11 years ago

Finished updating tests.

jimmystridh commented 11 years ago

Dance