search

faern / oneshot

Oneshot Rust channel working both in and between sync and async environments
Apache License 2.0
80 stars 9 forks source link

Remove `_dropck` flag from `SendError` #19

Closed Noratrieb closed 2 years ago

Noratrieb commented 2 years ago

The nomicon has been outdated about this since 2015, see rust-lang/nomicon#363 for the update. We don't need to tell dropck that we are owning a T as it can already infer that from the generic parameter in the drop impl.

cc @Cassy343 who added it

Cassy343 commented 2 years ago

Could this be modified to just remove the comment and explain instead that we'll need something like this if a #[may_dangle]-like thing ever gets stabilized?

faern commented 2 years ago

Looks like you force pushed a new commit that is identical?

Noratrieb commented 2 years ago

oh

faern commented 2 years ago

Thank you for the contribution!

faern commented 2 years ago

Aah. It should have been removed from the changelog as well! https://github.com/faern/oneshot/blob/3cee01f3ff91afa7691357494f87cbd3d2727446/CHANGELOG.md#fixed

I'll do that directly.

faern commented 2 years ago

https://github.com/faern/oneshot/commit/b84c62462a32f1ace2713fbf1eb09bee15dea6af