search

faern / oneshot

Oneshot Rust channel working both in and between sync and async environments
Apache License 2.0
80 stars 9 forks source link

Replace async-std with tokio due to memory leak #6

Closed faern closed 4 years ago

faern commented 4 years ago

Currently the automated memory leak tests fail. It seems because async-std does not properly join threads before exiting. I did a quick test under tokio and the issue does not seem to exist there. Maybe async-std will solve it, see this issue: https://github.com/async-rs/async-std/issues/759

faern commented 4 years ago

Fixed in 9f6fded595f58667f1d25d7c63584b71a2c2b689.

I should add back async-std and run all tests under it but without valgrind.. But that's a separate issue.