search

fafranco82 / swdestinydb-json-data

29 stars 46 forks source link

Plots with elite/non-elite options aren't being included in points #263

Open mlogie opened 4 years ago

mlogie commented 4 years ago

Clearly the db wasn't designed for elite and non-elite plots, but as is the points for the plots aren't being included. Either this needs to be fixed architecturally, which may be tricky, or all the plots (for now) just get set to their non-elite points cost, and people live with the fact that they have to just know that they're supposed to be elite. This is a similar issue to the elite/non-elite diceless characters and the elite non-unique characters. Perhaps the db needs a elite/non-elite flag in addition to the number of copies option, but this may require some work.

fafranco82 commented 4 years ago

I like the idea of elite/non-elite flag instead of assuming it with number of dice. I will think of this after my short vacation. Until this Wednesday I will not be back at home.

mlogie commented 4 years ago

Thanks. I think it's a good solution moving forward. But problem is: all already published decks have used the old system, of two copies of an elite card = elite. This means if you did migrate to this solution, you'd have to back update all decks which used the old system to reflect the new. I have literally no idea how complex this would be to implement. It would be nice to solve the problems with non-unique elites, elite plots and dice-less elites in one move though.