search

fagbokforlaget / pdftotextjs

pdftohtml nodejs wrapper
MIT License
20 stars 15 forks source link

Missing test file #8

Closed lirantal closed 8 years ago

lirantal commented 8 years ago

Tests are looking for a file called invalidfile.pdf which is missing:

    it('should add options', function(){
      var ptext = new pdftotext(__dirname + '/pdfs/invalidfile.pdf');
iapain commented 8 years ago

@lirantal Thats fine and error handler should be invoked when error occurs. May be you can describe this test better.

lirantal commented 8 years ago

that invalidfile.pdf doesn't exist at all so obviously anything that test tries to do will fail. So either that file is accidentally missing, or if we deliberately want to fail the test on missing file then I think the test should be corrected as well as it's name which doesn't suggest it.

iapain commented 8 years ago

It's deliberately missing but totally agree with you that we should describe it better.

lirantal commented 8 years ago

Okie, I'll fix the test.

lirantal commented 8 years ago

Closing via https://github.com/fagbokforlaget/pdftotextjs/pull/10