search

fagbokforlaget / simple-fs

Handles files on indexeddb like you would do in node.js (promise)
MIT License
152 stars 9 forks source link

Make storage pluggable #13

Closed iapain closed 4 years ago

iapain commented 4 years ago

For now storage is based on string based switch. With this PR, storage can be now passed in FileSystem class, hence makes it plugable. It will also allow people to write their own storage providers based on storage api.

Renames backend param -> storage param as well. (backward incompatible change)

This might be backward incompatible in some cases.

codecov[bot] commented 4 years ago

Codecov Report

Merging #13 into master will increase coverage by 1.56%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   85.36%   86.93%   +1.56%     
==========================================
  Files           8        8              
  Lines         205      199       -6     
  Branches       42       41       -1     
==========================================
- Hits          175      173       -2     
+ Misses         30       26       -4
Impacted Files Coverage Δ
src/storages/indexeddb.js 46.66% <ø> (+20.00%) :arrow_up:
src/storages/memory.js 100.00% <ø> (ø)
src/filesystem/filesystem.js 91.57% <100.00%> (+0.48%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 100b847...9557cea. Read the comment docs.