Fixes for you, in a different repo

[GoogleCodeExporter]

Hi,

I've been doing some fixes and pushed them up to this git repository:
https://github.com/paulharris/miniz

I imported the SVN repo, so all the SVN patches are contained within too.

Are you still active in this project?  There are quite a few open bugs that 
seem to be already fixed, or easily fixed elsewhere.

Also note that I'm not the only alternative miniz repo out there,
eg, this one has changes for working on Android:
https://github.com/codefireXperiment/external_libminiz

cheers,
Paul

Original issue reported on code.google.com by harris...@gmail.com on 8 Oct 2013 at 3:23

[GoogleCodeExporter]

Thanks Paul - Yes, I'm still active on miniz. I guess I'm not the best/fastest 
project maintainer though. I'm adding zip64 support to miniz for a project I'm 
doing at work, it's almost ready. After I test the hell out of zip64 I was 
going to merge in as many fixes/improvements as I could find and test it more 
before releasing an update.

Original comment by richge...@gmail.com on 8 Oct 2013 at 3:30

[GoogleCodeExporter]

Good to hear :)

If you shift to a git repo, then you can pull in fixes from other people.
I am not sure how you'd go about sucking my changes in with svn ?

If we merge, then its less hassle at my end.
If you copy-paste patches into your repo, then its more of a hassle for me to 
merge your changes into mine.

cheers,
Paul

Original comment by harris...@gmail.com on 8 Oct 2013 at 3:51

[GoogleCodeExporter]

by the way, I'm not sure you'll like my changes and the new layout,
but it allows me to do something like
gcc -I /path/to/miniz/include
and then
#include <miniz/miniz.c>

Also, this is a header-only library, with option to compile as a library.
So the file should probably technically be called miniz.h with an optional tiny 
miniz.c file for compiling as a library.

Its ok enough for me for now, but I'm wondering how you feel about changing the 
layout of the project.

Original comment by harris...@gmail.com on 8 Oct 2013 at 4:04

[GoogleCodeExporter]

This is how I use the library in practice.. So I can't see how I could resist 
the idea..
Also during development I usually split the thing up for readability, then put 
it back together once I'm done.

Original comment by richge...@gmail.com on 8 Oct 2013 at 4:09

[GoogleCodeExporter]

urgh.
i make a change, and the commit when i'm happy.  putting things together and 
taking them apart would break the flow.

with the current structure, you can break it up easily and leave it broken.
eg,
in miniz.h,
#include "miniz_a.h"
#include "miniz_b.h"
#include "miniz_c.h"

because its "" includes, it'll look in miniz.h's directory and find the correct 
files.

Then in your main project, you include with <>

Original comment by harris...@gmail.com on 8 Oct 2013 at 4:16

[GoogleCodeExporter]

I've merged your changes (and the changed from that other repo) into v1.15, and 
gave you some credits. Thanks a lot!

Original comment by richge...@gmail.com on 13 Oct 2013 at 5:27

• Changed state: Fixed