faheel / BigInt

Arbitrary-sized integer class for C++
https://faheel.github.io/BigInt
MIT License
390 stars 132 forks source link

GCD implementation using Euclid's algorithm #14

Closed anandsit043 closed 6 years ago

anandsit043 commented 6 years ago

Modified files : BigInt.hpp and operators/binary_arithmetic.hpp Please review

codecov-io commented 6 years ago

Codecov Report

Merging #14 into master will decrease coverage by 3.8%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   98.94%   95.14%   -3.81%     
==========================================
  Files          12       12              
  Lines         475      494      +19     
==========================================
  Hits          470      470              
- Misses          5       24      +19
Impacted Files Coverage Δ
include/BigInt.hpp 100% <ø> (ø) :arrow_up:
include/operators/binary_arithmetic.hpp 89.78% <0%> (-7.9%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 72a4c9f...392a87d. Read the comment docs.

faheel commented 6 years ago

@anandsit043 You have made changes directly to your master branch which causes a problem reporting code coverage due to an issue with Codecov. So it would be great if you could follow the steps in the contribution guidelines to create a new branch, add your changes there, and send a new PR from that branch.

faheel commented 6 years ago

Follow up in #15.