search

faheel / BigInt

Arbitrary-sized integer class for C++
https://faheel.github.io/BigInt
MIT License
390 stars 132 forks source link

Added GCD with tests #15

Closed anandsit043 closed 6 years ago

anandsit043 commented 6 years ago

Added test cases in math.test.cpp and corrected the friend function part as per PR review.

Relates to #5.

codecov[bot] commented 6 years ago

Codecov Report

Merging #15 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         473    492   +19     
=====================================
+ Hits          473    492   +19
Impacted Files Coverage Δ
include/functions/math.hpp 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 38ba375...f9af689. Read the comment docs.

anandsit043 commented 6 years ago

Hi @faheel, Done with all the mentioned changes.

faheel commented 6 years ago

There's still one left. Check the review above.

anandsit043 commented 6 years ago

Does it look good now? I will get started on LCM.

faheel commented 6 years ago

Yes, it does. Thank you!