faheem801 / flot

Automatically exported from code.google.com/p/flot
MIT License
0 stars 0 forks source link

Provide jquery.flot.js without inlined jquery.colorhelpers.js #413

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently jquery.flot.js includes an inline minified version of 
jquery.colorhelpers.js.
It would be easier for automated minification workflows to have a separate 
jquery.flot.js file without other libraries, especially minified versions.
The name could be jquery.flot.core.js

In addition a new convenience file could contain the uncompressed contents of 
jquery.colorhelpers.js and jquery.flot.js.
The name could be jquery.flot.base.js

Original issue reported on code.google.com by rene.leonhardt@gmail.com on 7 Sep 2010 at 6:29

GoogleCodeExporter commented 9 years ago
Hi! Why do you need that? When I make a release, I just reminify it, works fine?

Original comment by olau%iol...@gtempaccount.com on 14 Dec 2010 at 9:41

GoogleCodeExporter commented 9 years ago
The current jquery.flot.js is a mix of jquery.colorhelpers.js (minified) and - 
let's name it - jquery.flot.core.js (unminified).

When I want to include the current jquery.flot.js in static (YUI Compressor, 
Closure Compiler, ...) or dynamic (mod_pagespeed, ...) minification workflows, 
this mix can lead to problems or even errors.

Therefore I would appreciate two separate files, at least in unminified 
versions.
Or as alternative one unmified mix file (and probably a minified version, too).

Original comment by rene.leonhardt@gmail.com on 14 Dec 2010 at 10:20

GoogleCodeExporter commented 9 years ago
Sorry, I think I was maybe to vague.

The thing is it's going to be more work for me and potentially more cumbersome 
for other people, so unless you actually have experienced a problem, I'd rather 
not change it. And even if you get a problem, I'd actually rather do something 
to fix that than change the workflow.

As I mentioned, when I make a Flot release and minify the files with YUI 
Compressor, I just run the jquery.flot.js file through YUI Compressor (you can 
see that in the Makefile). It works fine.

Original comment by olau%iol...@gtempaccount.com on 15 Dec 2010 at 12:15

GoogleCodeExporter commented 9 years ago
I'm going to close this now due to inactivity, if you do find a problem, please 
let us know.

Original comment by olau%iol...@gtempaccount.com on 10 Mar 2011 at 4:19

GoogleCodeExporter commented 9 years ago

Original comment by dnsch...@gmail.com on 4 Jun 2012 at 2:41