fahim-tazz / pe

0 stars 0 forks source link

DG says all arguments to EditPolicy are optional #10

Open fahim-tazz opened 1 year ago

fahim-tazz commented 1 year ago

According to the DG Edit Policy Feature, all arguments to editPolicy are optional.

image.png

However, this is not true, since at least one of those arguments have to be entered, but this is not made clear in the Developer Guide. It is easy for future developers to miss this small detail when they build on top of Advisio.

nus-pe-script commented 1 year ago

Team's Response

Screenshot 2023-04-16 at 4.32.50 PM.png

It was mentioned that editPolicy can only have at least one of the optional field present in the user guide. This does not cause inconvenience to the user who is using the application because he will be getting the information from the user guide and not the developer guide.

However, in the developer guide, the statement is stating that each of the class names are individually optional which is true. The statement is not referring to the usage of the command editPolicy which has already been and is addressed in the user guide.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]