search

fahim-tazz / pe

0 stars 0 forks source link

Find command follows the indexing of the main list, not the list that is shown #2

Open fahim-tazz opened 1 year ago

fahim-tazz commented 1 year ago

Starting at the main list. Note the index of Bernice Yu:

image.png

Use find command to look for Doe:

image.png

The search results list Jamie Doe as #1. However, using the select command on anyone from the shown list follows the indexing of the main list.

image.png

The console shows that Jamie Doe was selected, but the profile view on the right points to Bernice Yu.

nus-pe-bot commented 1 year ago

Team's Response

This behaviour is a result of the the usage of the filteredClientList, which we mentioned in the Planned Enhancements of our Developer Guide that we plan to improve this mechanism as it is not intuitive to the user.

The find command doesn't follow the proper indexing for now but this problem does not occur when the entire client list is displayed.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: My reasoning for choosing severity.Medium:

The workflow of using find, then selecting a user from the resulting list is not an uncommon use case. Therefore, it is not a bug that "appears in only rare situations" (according to PE guidelines below).

image.png

And while the DG may acknowledge the reasons for this indexing discrepancy, and there is definitely room for further improvement in future versions, according to the PE guidelines, acknowledging a bug is not a reason to dismiss/downplay the severity of the bug in this iteration.