search

fahim-tazz / pe

0 stars 0 forks source link

Discrepancy between indexes of Commands Select vs Any Other Commands #3

Open fahim-tazz opened 1 year ago

fahim-tazz commented 1 year ago

(EXTENSION FROM #2)

As reported in #2, using select after find uses the indexes of the main list, rather than what is shown in the current client list.

However, when using edit or delete after find, the indexing matches the search results of Find.

This discrepancy between indexing of different commands leads to the user selecting one profile, then editing a different profile. For example:

  1. User searches for Doe:

image.png

  1. User edits index 1, which correctly edits Jane Doe.
  2. User selects index 1, only to load Alex Yeoh's profile from the main list

image.png

Suggestion: To remove this discrepancy and make a consistent user experience, try to use the same/similar indexing even after Find.

soc-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Find command follows the indexing of the main list, not the list that is shown

Starting at the main list. Note the index of Bernice Yu:

image.png

Use find command to look for Doe:

image.png

The search results list Jamie Doe as #1. However, using the select command on anyone from the shown list follows the indexing of the main list.

image.png

The console shows that Jamie Doe was selected, but the profile view on the right points to Bernice Yu.

[original: nus-cs2103-AY2223S2/pe-interim#4391] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This behaviour is a result of the the usage of the filteredClientList, which we mentioned in the Planned Enhancements of our Developer Guide that we plan to improve this mechanism as it is not intuitive to the user.

The find command doesn't follow the proper indexing for now but this problem does not occur when the entire client list is displayed.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The "duplicate" talks about functionality of the select command. This new issue talks about edit and delete commands. While they are caused by the same steps (find), it is still a discrepancy on both ends (select and edit/delete). This is why I reported it as a different issue, because as a User, it is difficult for me to understand the different indexing for both select and delete/edit, not just select.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** My reasons for `severity.Medium` is the same as the "duplicate": using `edit`/`delete` after `find` is not an uncommon use case, so `severity.Low` does not apply.