Highlight in Ctrl + Shift + F

fahimmehraj / jetbrains-kanagawa-theme

Kanagawa Theme for JetBrains IDEs

MIT License

22 stars 12 forks source link

Highlight in Ctrl + Shift + F #3

Closed BButner closed 2 months ago

BButner commented 1 year ago

If you see the below image, using Ctrl + Shift + F to "Find in Files", the highlight text color and background makes it almost unreadable:

Manuzor commented 1 year ago

This is the main blocker for me. I've been skimming through the catppuccin theme, which doesn't have this problem, and found that they're defining selectionInactiveForeground (see screenshot) while Kanagawa Theme doesn't. Maybe that is the problem?

Unfortunately I don't know how to test locally, otherwise I'd create a PR.

fahimmehraj commented 4 months ago

Is this still a problem for anyone? I don't think that setting has any effect anymore in version 2024.1. I'm using the macOS version.

Jonassen commented 3 months ago

I'm still having this problem in IDEA Ultimate 2024.2 on MacOS with plugin version 1.1.6. I'm not aware of any colors I've overridden.

Edit: I noticed the screenshot in the above post refers to the generic search-box which is working fine while OP refers to find in files which is still broken.

fahimmehraj commented 2 months ago

Fixed by 56ff4f9