fahrinh / azan-gnome-shell-extension

Azan is an Islamic prayer times extension for Gnome Shell
28 stars 27 forks source link

Not compatible with Gnome 4.0 #12

Open ameeno opened 3 years ago

ameeno commented 3 years ago

Hi I am on gnome 4.0 arch. cannot get this to work. extensions.gnome.org says incompatible. how can we fix it?

hydroEng commented 2 years ago

Someone please consider porting this to Gnome 40. This is one of the most useful extensions I've used 🙂.

جزاكم الله خير

tes123id commented 2 years ago

is there a way to install this on gnome 40 ? this is an amazing extension, very useful

minax007 commented 2 years ago

@ameeno @suryaya @tes123id

To get it working in gnome 40 you just need to add "40" in the metadata.json file and restart your system (or alt+F2 and enter "r" followed by a return).

"shell-version": [ "3.28.3", "3.26.1", "40" ],

minax007 commented 2 years ago

Gnome 40 and Gnome 41 work fine.

But with Gnome 42 it doesn't work anymore.

Does anyone have an idea what to do?

@ameeno I see that you are an expert and that you have forked this repository. Do you have a clue what is needed?

Thanks!

ahmetbombaci commented 2 years ago

I briefly checked the issue but I could not make a lot of progress. Sharing what I did here in case someone else can make more progress.

Initial error that I got after upgrading Gnome 42:

margin_left not found.

I checked https://docs.gtk.org/gtk4/class.StackSwitcher.html so I updated prefs.js (line 204 and 207):

I restarted my gnome shell via (Alt+F2) ---> r

Then, I got another error:

Error: GSettings key undefined not found in schema org.gnome.shell.extensions.azan

Line number indicated an issue related Calculation Method key definition but I am not so sure what needs to be changed.

I checked my other extensions which works fine with Gnome 42 and uses PrefsKeys and I found the following:

https://github.com/justperfection/blur-my-shell

I am not so sure what is the best strategy to resolve the issue:

"Reading Gtk4 documentation" vs "Checking blur my shell code to understand which kind of setup needs to be done to read keys"

....