faif / python-patterns

A collection of design patterns/idioms in Python
40.39k stars 6.94k forks source link

Corrupted git file history #298

Closed fkromer closed 5 years ago

fkromer commented 5 years ago

I am looking for a new employment right now and thought about letting people know about my contributions in this repository. Unfortunately this PR corrupted the git file history. The project's contribution overview does not show contributions correctly anymore and it's also not possible to get the information with git log. It would be great if someone could fix that. This gist about how to move files without loosing the file history could be a starting point.

gyermolenko commented 5 years ago

hi @fkromer , sorry to hear that my PR created inconveniences for someone. It was tracked as git mv action (rename), which is not a crime by my book.

Can you please try git log --follow <filename> command? E.g. git log --follow patterns/behavioral/catalog.py shows history before catalog structure has changed.

Update: instructions from the link you provided do git mv and then git log --follow. That wont change anything. Github doesn't support follows.

There is a Chrome extension and unofficial ticket for asking for this github feature to be implemented

fkromer commented 5 years ago

@gyermolenko Thanks for this super fast response. Using git log on files like e.g. git log --follow patterns/other/hsm/hsm.py works. However my hope was that it is possible to restore the log information on the publicly accessible project site and in my account's contribution activites somehow. Good to know that GitHub's user contribution statistics are that unreliable. The unofficial ticket for native support got another thumbs up :)

gyermolenko commented 5 years ago

I've just checked, and if you copy repo from github to gitlab - their file history follows git renames. As an option - to put gitlab link with disclaimer into resume so it can be used simply like alternative git web ui with more representative file history

fkromer commented 5 years ago

The GitHub repo pull mirrored into GitLab displays project contributions and git file historys correctly.