search

faif / python-patterns

A collection of design patterns/idioms in Python
40.45k stars 6.94k forks source link

'next_number' #305

Closed akkaboss closed 4 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #305 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   32.82%   32.82%           
=======================================
  Files          42       42           
  Lines        1496     1496           
=======================================
  Hits          491      491           
  Misses       1005     1005

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e13574b...bc8cfad. Read the comment docs.

faif commented 5 years ago

Hi,

Thanks for the pull request, but as is, it doesn't adhere to the coding conventions. A test file should start with the prefix test_ and should use the unittest module. Please check the structure of the existing tests and make the relevant modifications.

gyermolenko commented 4 years ago

I think this PR can be safely closed