Fix tests - Githubissues

faif / python-patterns

A collection of design patterns/idioms in Python

40.46k stars 6.94k forks source link

Fix tests #348

Closed imankulov closed 4 years ago

imankulov commented 4 years ago

It looks like the tests for the project went out of sync with the code, and running tox against the master branch breaks on several occasions.

This PR fixes the tests to make tox happy again. More specifically:

Rewrites tests for the Proxy class.
Fixes the tests for the borg.
Fixes some Flake8 rules.

faif commented 4 years ago

Thanks. I remember that travis also used to trigger the tests automatically on every pull request. Any idea what has caused it to stop?

imankulov commented 4 years ago

I can see Travis still works (and by the way, there's a problem with tests under Python3.7): https://travis-ci.org/github/faif/python-patterns/pull_requests

faif commented 4 years ago

I see. Then what has stopped working is the integration between github/travis in the pull request. It used to trigger the tests for each pull request and return the status so it was easy to see possible regressions