TolstochenkoDaniil commented 3 years ago

373

faif commented 3 years ago

@TolstochenkoDaniil Can you please fix the linter errors? If it's too much work for all, at least only for the files that you modified.

TolstochenkoDaniil commented 3 years ago

for

@TolstochenkoDaniil Can you please fix the linter errors? If it's too much work for all, at least only for the files that you modified.

I'll check the errors, but tox completed ok before commit Will do my best

codecov-commenter commented 3 years ago

Codecov Report

Merging #374 (c0677d7) into master (4fcbf1b) will increase coverage by 2.28%. The diff coverage is 96.42%.

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   30.87%   33.15%   +2.28%     
==========================================
  Files          39       39              
  Lines        1286     1306      +20     
==========================================
+ Hits          397      433      +36     
+ Misses        889      873      -16

Impacted Files	Coverage Δ
patterns/structural/3-tier.py	`0.00% <ø> (ø)`
patterns/structural/front_controller.py	`0.00% <ø> (ø)`
patterns/behavioral/strategy.py	`90.00% <96.42%> (+90.00%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fcbf1b...c0677d7. Read the comment docs.

faif commented 3 years ago

Let's create a new issue for the remaining linter errors

faif / python-patterns

Added type hints and pytest tests #374

373

Codecov Report