search

faif / python-patterns

A collection of design patterns/idioms in Python
40.2k stars 6.93k forks source link

Add Protocol to factory pattern #402

Closed mfurquimdev closed 1 year ago

mfurquimdev commented 1 year ago

Hi 👋🏽

I see we have some type hints that's been continuously added as mentioned at #373.

As the factory pattern has the constrain of both classes having to implement a localize method, I thought it might be a good idea to reinforce this constrain by using Protocol.

I'd gladly implement this if it's okay.

Here's the PEP-0544 and the Python docs for Protocols.

faif commented 1 year ago

Hi,

Sure, go ahead.