search

faiface / beep

A little package that brings sound to any Go application. Suitable for playback and audio-processing.
MIT License
2.06k stars 153 forks source link

Upgrade oto v0.6.1->v0.7.1 #101

Closed deryrahman closed 3 years ago

deryrahman commented 4 years ago

Upgrading the oto version to fix #77

faiface commented 3 years ago

Hey, sorry for only coming to you now. Does this PR still work? Can I merge it?

deryrahman commented 3 years ago

@faiface yups, you can safely merge it

makew0rld commented 3 years ago

The latest version of oto is v0.7.0. Can all dependencies be updated, and the suggestion that users install with -u removed? Using -u means users will all be using different dependencies, and so some will have issues and some will not.

makew0rld commented 3 years ago

Now the latest oto version is 0.7.1. @faiface can you upgrade all deps? This will resolve issues like #94 as well. If the project is abandoned or you need a new maintainer please let us now. Thank you!

deryrahman commented 3 years ago

@makeworld-the-better-one can you help me to check whether 0.7.1 would resolve the issue or not? I've already upgraded it to v0.7.1

makew0rld commented 3 years ago

Actually I don't have access to a Mac right now so I can't test. I think #77 is already resolved in master, but between oto v0.6.1 and v0.7.1 there were a lot of Mac specific fixes that should be used in this repo anyway. So I'd still think this is important to merge.

Unfortunately @faiface seems to be absent.

faiface commented 3 years ago

Sorry, I’m here, merging right now.

It is true, though, that a new maintainer would be appreciated.

makew0rld commented 3 years ago

@faiface Woohoo! Thanks for coming in. Might be good to mention the need for a maintainer on the README. And look at the other PRs when you have time.